[
https://issues.apache.org/jira/browse/YARN-6366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006564#comment-16006564
]
Shane Kumpf commented on YARN-6366:
-----------------------------------
Thanks for the review, [~vvasudev]!
I will put together a patch to address a bulk of the above.
Regarding #4) Moving the conversion methods into ProtoUtils creates a circular
dependency between hadoop-common and the nodemanager. Would a consolidated
NMProtoUtils within the nodemanager module suffice?
Regarding #5) If you take a look at the diff for that test, the existing test
passes an empty Path array. I've tried to keep the test functionally the same.
{code}
- FileDeletionTask dependentDeletionTask =
- del.createFileDeletionTask(null, userDirPath, new Path[] {});
+ FileDeletionTask dependentDeletionTask = new FileDeletionTask(del, null,
+ userDirPath, new ArrayList<>());
{code}
> Refactor the NodeManager DeletionService to support additional DeletionTask
> types.
> ----------------------------------------------------------------------------------
>
> Key: YARN-6366
> URL: https://issues.apache.org/jira/browse/YARN-6366
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager, yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-6366.001.patch, YARN-6366.002.patch,
> YARN-6366.003.patch, YARN-6366.004.patch, YARN-6366.005.patch,
> YARN-6366.006.patch
>
>
> The NodeManager's DeletionService only supports file based DeletionTask's.
> This makes sense as files (and directories) have been the primary concern for
> clean up to date. With the addition of the Docker container runtime, addition
> types of DeletionTask are likely to be required, such as deletion of docker
> container and images. See YARN-5366 and YARN-5670. This issue is to refactor
> the DeletionService to support additional DeletionTask's.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
