[
https://issues.apache.org/jira/browse/YARN-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007184#comment-16007184
]
Carlo Curino commented on YARN-5328:
------------------------------------
Thanks [~subru] for the contribution.
Reviewing now, patch looks generally good, there are some format-fixes (correct
though not strictly needed... I am ok with them).
One thing I think is not currently correct is the handling of {{resCount}}. You
should assign earliestStartTime and endTime for periodic case.
The earliestStartTime should be: the absolute start time of the periodic
reservation, while the endTime should be Long.MAX_VALUE.
Other than that the patch is +1 pending fixes on unit-test and findbugs per
yetus complaining.
> InMemoryPlan enhancements required to support recurring reservations in the
> YARN ReservationSystem
> --------------------------------------------------------------------------------------------------
>
> Key: YARN-5328
> URL: https://issues.apache.org/jira/browse/YARN-5328
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subru Krishnan
> Assignee: Subru Krishnan
> Attachments: YARN-5328-v1.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the
> YARN ReservationSystem. This JIRA is a sub-task to track the changes required
> in InMemoryPlan to accomplish it. Please refer to the design doc in the
> parent JIRA for details.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
