[
https://issues.apache.org/jira/browse/YARN-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008604#comment-16008604
]
Carlo Curino commented on YARN-6528:
------------------------------------
Thanks [~seanpo03] for contributing this.
Code comments:
# In {{InMemoryPlan.updateReservation()}} you add to the metrics both during
catch and finally... isn't this double counting? See if you could consistently
do this in {{finally}} and use {{result}}, would make it easy to evolve as well.
# {{PlanFollowerMetrics }} class javadoc is a little funny, please fix up the
explanation (e.g., refer to {{synchronizePlan}} as a code reference and not as
'synchronize' in text which people would confuse for any synchronized method,
etc..)
# I am uncertain between doing things on a per-plan basis (like I proposed in
YARN-6548 for a partially overlapping set of metrics to what you track here),
or maintain only global counters like you do here.
# Can you explain the rational of agent vs plan counters/quantiles? Do we need
both?
Thanks,
Carlo
> Add JMX metrics for Plan Follower and Agent Placement and Plan Operations
> -------------------------------------------------------------------------
>
> Key: YARN-6528
> URL: https://issues.apache.org/jira/browse/YARN-6528
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Sean Po
> Assignee: Sean Po
> Attachments: YARN-6528.v001.patch, YARN-6528.v002.patch
>
>
> YARN-1051 introduced a ReservationSytem that enables the YARN RM to handle
> time explicitly, i.e. users can now "reserve" capacity ahead of time which is
> predictably allocated to them. In order to understand in finer detail the
> performance of Rayon, YARN-6528 proposes to include JMX metrics in the Plan
> Follower, Agent Placement and Plan Operations components of Rayon.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
