[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009593#comment-16009593
]
Wangda Tan commented on YARN-5949:
----------------------------------
Thanks [~jhung] for updating the patch,
Few comments:
1) Do you think is it better to rename
"...scheduler.configuration.mutation.policy.class" to
"...scheduler.configuration.mutation.acl-policy.class"? "policy" is too general
to me. If you think it is better, I suggest to rename all related
classes/fields.
2) In yarn-default.xml, it's better to add a note to say
"DefaultConfigurationMutationPolicy" is using admin-acl config?
3) Is there any test added with the patch? Is it possible to add basic tests?
> Add pluggable configuration policy interface as a component of
> MutableCSConfigurationProvider
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-5949
> URL: https://issues.apache.org/jira/browse/YARN-5949
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Attachments: YARN-5949-YARN-5734.001.patch,
> YARN-5949-YARN-5734.002.patch, YARN-5949-YARN-5734.003.patch,
> YARN-5949-YARN-5734.004.patch
>
>
> This will allow different policies to customize how/if configuration changes
> should be applied (for example, a policy might restrict whether a
> configuration change by a certain user is allowed). This will be enforced by
> the MutableCSConfigurationProvider.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
