[
https://issues.apache.org/jira/browse/YARN-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030304#comment-16030304
]
Maya Wexler commented on YARN-6477:
-----------------------------------
bq. The patch doesn't appear to include any new or modified tests. Please
justify why no new tests are needed for this patch. Also please list what
manual steps were performed to verify this patch.
This patch is a removal of an annotation that suppresses a warning, so no new
tests are required. With the annotation's removal, there are still no
compilation warnings for the Dispatcher interface. I manually ran the unit
tests in hadoop-yarn-common and they all passed.
bq. adoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant
Findbugs warnings.
Unrelated to this patch, as it's a potential NP in a different class
(org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogValue)
> Dispatcher no longer needs the raw types suppression
> ----------------------------------------------------
>
> Key: YARN-6477
> URL: https://issues.apache.org/jira/browse/YARN-6477
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Daniel Templeton
> Assignee: Maya Wexler
> Priority: Minor
> Labels: newbie
> Attachments: YARN-6477.001.patch
>
>
> Post YARN-4457, the {{@SuppressWarnings("rawtypes")}} is no longer needed in
> the Dispatcher class.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
