[
https://issues.apache.org/jira/browse/YARN-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033995#comment-16033995
]
Carlo Curino commented on YARN-6634:
------------------------------------
[~giovanni.fumarola] The patch generally looks good, reasonable refactoring for
YARN-6634.
Please go over the javadoc and clean them up a bit. Example of small issues:
* Some of the comments only make sense for RM as an implementor, e.g., {{*
@throws NotFoundException if the ResourceScheduler is null}}
* Some of the text you use misleading capitalizations e.g.,: {{* @throws
Exception in case of a BadRequest}} where BadRequest is not a java object.
* Comments of the kind {{Use with @link RMWSConsts#SCHEDULER.}} are not very
helpful. Briefly state what the method does, beside how to use it.
I understand you have in general removed exceptions where were never thrown
(generally good). Why adding adding {{NotFoundException}} to
{{getSchedulerInfo}}, {{getNodes}}, etc..?
Other than these nits, I am sure yetus would have caught any other issues, so I
am good for the patch to get committed. [~leftnoteasy], since you first
reviewedd, do you want to do the commit? (please push to branch-2 as well if
possible).
> [API] Define an API for ResourceManager WebServices
> ---------------------------------------------------
>
> Key: YARN-6634
> URL: https://issues.apache.org/jira/browse/YARN-6634
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Subru Krishnan
> Assignee: Giovanni Matteo Fumarola
> Priority: Critical
> Attachments: YARN-6634.proto.patch, YARN-6634.v1.patch,
> YARN-6634.v2.patch, YARN-6634.v3.patch, YARN-6634.v4.patch, YARN-6634.v5.patch
>
>
> The RM exposes few REST queries but there's no clear API interface defined.
> This makes it painful to build either clients or extension components like
> Router (YARN-5412) that expose REST interfaces themselves. This jira proposes
> adding a RM WebServices protocol similar to the one we have for RPC, i.e.
> {{ApplicationClientProtocol}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
