[
https://issues.apache.org/jira/browse/YARN-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035387#comment-16035387
]
Carlo Curino commented on YARN-6547:
------------------------------------
[~leftnoteasy], patch v2 addresses your ask to leave {{JvmMetrics.init}}
unchanged, I invoke a {{registerIfNeeded}} method in {{SLSRunner.startRM()}},
to make sure the existing {{JvmMetrics}} object is picked up across
parametrized runs of {{TestSLSRunner}}. It seems to work correctly in my local
tests.
I decided to postpone to a separate patch the use of reservation metrics as
part of the invariants we check, as work on YARN-6528 will take a little longer
(and I would like to commit this patch, and cherry-pick it back to 2.7ish
branches we use internally).
My goal is to eventually workout a tighter set of invariants to check for doing
performance validations as well as correctness checks using this invariants
mechanism. This will require some assumptions on the build enviroment, but if
we work out those it is likely worth it as it could catch perf regressions,
which are otherwise hard to spot till deployment.
> Enhance SLS-based tests leveraging invariant checker
> ----------------------------------------------------
>
> Key: YARN-6547
> URL: https://issues.apache.org/jira/browse/YARN-6547
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-6547.v0.patch, YARN-6547.v1.patch,
> YARN-6547.v2.patch
>
>
> We can leverage {{InvariantChecker}}s to provide a more thorough validation
> of SLS-based tests. This patch introduces invariants checking during and at
> the end of the run.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
