[ 
https://issues.apache.org/jira/browse/YARN-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039616#comment-16039616
 ] 

Billie Rinaldi commented on YARN-6669:
--------------------------------------

Hi [~jianhe], I took a look at the patch. A couple of comments:
* Is the principal definitely going to be a valid HDFS file name, even if it 
has a / in it?
* In SliderAppMaster, we don't need to create a new configuration variable 
"private Configuration configuration;" just call getConfig() to get the 
configuration from the superclass.
* SecurityConfiguration#isKeytabProvided is no longer used.

I don't see any other issues, though I haven't tested out the patch with 
Kerberos.

> Kerberos support for native service AM with the service REST API
> ----------------------------------------------------------------
>
>                 Key: YARN-6669
>                 URL: https://issues.apache.org/jira/browse/YARN-6669
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-6669.yarn-native-services.01.patch, 
> YARN-6669.yarn-native-services.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to