[
https://issues.apache.org/jira/browse/YARN-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042168#comment-16042168
]
Daniel Templeton commented on YARN-6697:
----------------------------------------
Thanks, [~linzhangbing].
In {{DeletionService}}, I don't see the need to log the exception. The only
case it happens is if the service is stopped. If the service is stopping, I
don't see a reason to add another log line that says some little part of the
service just stopped. If you want to put something between the braces, I'd put
a comment that says the interrupted case is also handled through the
{{terminated}} variable.
In {{ResourceLocalizationService}}, you're right, a log message is needed, and
it should be an error. Let's make the message as clear and actionable as
possible, though. What caused the exception, in layman's terms? What should
the admin do about it? What are the implications of the exception? Anywhere
in particular they should look for misconfigurations or other issues?
> Catch an exception, exception information needs to be recorded, even if the
> probability of occurrence is very low
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6697
> URL: https://issues.apache.org/jira/browse/YARN-6697
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 3.0.0-alpha4
> Reporter: ZhangBing Lin
> Assignee: ZhangBing Lin
> Priority: Minor
> Attachments: YARN-6697.001.patch
>
>
> Catch an exception, exception information needs to be recorded, even if the
> probability of occurrence is very low.I think a good programming habit is
> needed to do this, it's just what I think
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
