[ 
https://issues.apache.org/jira/browse/YARN-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056212#comment-16056212
 ] 

ASF GitHub Bot commented on YARN-6674:
--------------------------------------

Github user haibchen commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/240#discussion_r123053318
  
    --- Diff: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TestCGroupsMemoryResourceHandlerImpl.java
 ---
    @@ -169,4 +170,33 @@ public void testPostComplete() throws Exception {
       public void testTeardown() throws Exception {
         Assert.assertNull(cGroupsMemoryResourceHandler.teardown());
       }
    +
    +  @Test
    +  public void testOpportunistic() throws Exception {
    +    Configuration conf = new YarnConfiguration();
    +    conf.setBoolean(YarnConfiguration.NM_PMEM_CHECK_ENABLED, false);
    +    conf.setBoolean(YarnConfiguration.NM_VMEM_CHECK_ENABLED, false);
    +
    +    String id = "container_01_01";
    +    ContainerId mockContainerId = mock(ContainerId.class);
    +    when(mockContainerId.toString()).thenReturn(id);
    +
    +    cGroupsMemoryResourceHandler.bootstrap(conf);
    --- End diff --
    
    We can move this right above cgroupMemResourceHandler.prestart() similarly


> Add memory cgroup settings for opportunistic containers
> -------------------------------------------------------
>
>                 Key: YARN-6674
>                 URL: https://issues.apache.org/jira/browse/YARN-6674
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Haibo Chen
>            Assignee: Miklos Szegedi
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to