[ https://issues.apache.org/jira/browse/YARN-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059742#comment-16059742 ]
ASF GitHub Bot commented on YARN-6668: -------------------------------------- Github user szegedim commented on a diff in the pull request: https://github.com/apache/hadoop/pull/241#discussion_r123577788 --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java --- @@ -588,6 +589,31 @@ private void initializeProcessTrees( } /** + * Get the best process tree calculator. + * @param pId container process id + * @return process tree calculator + */ + private ResourceCalculatorProcessTree + getResourceCalculatorProcessTree(String pId) { + ResourceCalculatorProcessTree pt = null; + + // CGroups is best in perforance, so try to use it, if it is enabled + if (processTreeClass == null && --- End diff -- Impossible. CGroupsResourceCalculator relies on cgroups that are present only in node manager. ResourceCalculatorProcessTree is hadoop-yarn.common package > Use cgroup to get container resource utilization > ------------------------------------------------ > > Key: YARN-6668 > URL: https://issues.apache.org/jira/browse/YARN-6668 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 3.0.0-alpha3 > Reporter: Haibo Chen > Assignee: Miklos Szegedi > > Container Monitor relies on proc file system to get container resource > utilization, which is not as efficient as reading cgroup accounting. We > should in NM, when cgroup is enabled, read cgroup stats instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org