[ 
https://issues.apache.org/jira/browse/YARN-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077330#comment-16077330
 ] 

Yufei Gu commented on YARN-6757:
--------------------------------

Uploaded a new patch. 
1. fixed. 
2. {{CGroupsHandler.getValidCGroups()}} should be OK since EnumSet keep the 
enum instead of its name string. It's easier for callers to use name string 
HashSet.
3. 4. 5. 6. fixed.
7. Yes, it's weird, but we cannot do anything about it.
8. Fixed partially. Need the offline discussion, then I can post a new patch.


> Refactor the usage of 
> yarn.nodemanager.linux-container-executor.cgroups.mount-path
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-6757
>                 URL: https://issues.apache.org/jira/browse/YARN-6757
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Minor
>         Attachments: YARN-6757.000.patch, YARN-6757.001.patch
>
>
> We should add the ability to specify a custom cgroup path. This is how the 
> documentation of {{linux-container-executor.cgroups.mount-path}} would look 
> like:
> {noformat}
>     Requested cgroup mount path. Yarn has built in functionality to discover
>     the system cgroup mount paths, so use this setting only, if the discovery 
> does not work.
>     This path must exist before the NodeManager is launched.
>     The location can vary depending on the Linux distribution in use.
>     Common locations include /sys/fs/cgroup and /cgroup.
>     If cgroups are not mounted, set 
> yarn.nodemanager.linux-container-executor.cgroups.mount
>     to true. In this case it specifies, where the LCE should attempt to mount 
> cgroups if not found.
>     If cgroups is accessible through lxcfs or some other file system,
>     then set this path and 
> yarn.nodemanager.linux-container-executor.cgroups.mount to false.
>     Yarn tries to use this path first, before any cgroup mount point 
> discovery.
>     If it cannot find this directory, it falls back to searching for cgroup 
> mount points in the system.
>     Only used when the LCE resources handler is set to the 
> CgroupsLCEResourcesHandler
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to