[
https://issues.apache.org/jira/browse/YARN-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078799#comment-16078799
]
Subru Krishnan commented on YARN-6776:
--------------------------------------
Thanks [~asuresh] for the patch, it looks a fairly straightforward refactoring.
This is redundant:
{code}updateContainerErrors = new ArrayList<>(updateContainerErrors);
allocatedContainers = new ArrayList<>(allocatedContainers);
{code}
Can you also fix the checkstyle warnings?
> Refactor ApplicaitonMasterService to move actual processing logic to a
> separate class
> -------------------------------------------------------------------------------------
>
> Key: YARN-6776
> URL: https://issues.apache.org/jira/browse/YARN-6776
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Priority: Minor
> Attachments: YARN-6776.001.patch
>
>
> Minor refactoring to move the processing logic of the
> {{ApplicationMasterService}} into a separate class.
> The per appattempt locking as well as the extraction of the appAttemptId etc.
> will remain in the ApplicationMasterService
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
