[
https://issues.apache.org/jira/browse/YARN-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081132#comment-16081132
]
Arun Suresh commented on YARN-6706:
-----------------------------------
Yup. Agree this can go into trunk.
The patch generally looks good. One comment:
In the {{ContainerScheduler#scheduleContainer()}}, I see how
startPendingContainers() will ensure that we do not have to wait for a
completed container to start containers, but it maybe be better to just move
all the {{startPendingContainers()}} invocations from inside the if..then..else
to the last line of the method. Not sure if startPendingContainers() before and
after en-queuing is usefull.
> Refactor ContainerScheduler to make oversubscription change easier
> ------------------------------------------------------------------
>
> Key: YARN-6706
> URL: https://issues.apache.org/jira/browse/YARN-6706
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha3
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Attachments: YARN-6706.01.patch, YARN-6706-YARN-1011.00.patch,
> YARN-6706-YARN-1011.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
