[
https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yufei Gu updated YARN-6307:
---------------------------
Description:
The method does three things: compare the min share usage, compare fair share
usage by checking weight ratio, break tied by submit time and name. They are
mixed with each other which is not easy to read and maintenance, poor style.
Additionally, there are potential performance issues, like no need to calculate
weight ratio every time.
was:
The method does three things: check the min share ratio, check weight ratio,
break tied by submit time and name. They are mixed with each other which is not
easy to read and maintenance, poor style. Additionally, there are potential
performance issues, like no need to calculate weight ratio every time.
> Refactor FairShareComparator#compare
> ------------------------------------
>
> Key: YARN-6307
> URL: https://issues.apache.org/jira/browse/YARN-6307
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-6307.001.patch
>
>
> The method does three things: compare the min share usage, compare fair share
> usage by checking weight ratio, break tied by submit time and name. They are
> mixed with each other which is not easy to read and maintenance, poor style.
> Additionally, there are potential performance issues, like no need to
> calculate weight ratio every time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
