[ 
https://issues.apache.org/jira/browse/YARN-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085910#comment-16085910
 ] 

Rohith Sharma K S commented on YARN-6819:
-----------------------------------------

Thanks [~bibinchundatt] for the patch.. 

I see many potential issue after YARN-5006 which are not handled gracefully. 
Can you confirm all of these with UT/FT test cases?
# It looks like for rejected app, state transition is not complete. The 
application will remain final_saving state only. Final state is not updated!
# Since state transition is not complete, the application *finish time* will 
not be updated.

Comments on the patch
# Can you add proper log message with reason. The current log message bit 
confusing at least for me. 
# Add a FT test case to check proper transition is happened. And also verify 
with application report for this app. 

> Application report fails if app rejected due to nodesize
> --------------------------------------------------------
>
>                 Key: YARN-6819
>                 URL: https://issues.apache.org/jira/browse/YARN-6819
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6819.001.patch
>
>
> In YARN-5006 application rejected when nodesize limit is exceeded. 
> {{FinalSavingTransition}} stateBeforeFinalSaving  not set after skipping save 
> to store which causes application report failure



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to