[ 
https://issues.apache.org/jira/browse/YARN-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086246#comment-16086246
 ] 

Subru Krishnan commented on YARN-6807:
--------------------------------------

Thanks [~tanujnay] for addressing my feedback. 

The latest patch is close, I just have a few minor comments:
* Looks like you missed one of my comments - {quote} Please clarify why we need 
the additional configs in client yarn-site.xml. {quote}
* Use the description below for *FederationRMFailoverProxyProvider*: {quote} 
The class used to connect to the RMs by looking up the membership information 
in federation state-store. This must be set if federation is enabled, even if 
RM HA is not enabled.  {quote}
* The command to start the router appears twice, you can remove the first 
occurrence as it's redundant.
* In the sample job, a note calling out to use a large enough number of mappers 
so that the job requires to be federated, i.e. larger than a single cluster 
(happens to be 16 in the example) will be useful.
* In the output, please include more context (map/reduce progress) and more 
importantly clearly call out that there's no code change or even recompile 
needed to run existing sample and output is same.
* I am working on YARN-6821 which reminded me that:
** we have to explicitly call out running the SQL scripts to create the tables 
and stored proc. Can you do that as part of a new _FederationStateStore_ 
sub-section as part of the configuration or before starting the clusters.
** in the main _FederationStateStore_ section, we have to call out that before 
we describe the GPG that this part of future work and link to YARN-5597.

> Adding required missing configs to Federation configuration guide based on 
> e2e testing
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-6807
>                 URL: https://issues.apache.org/jira/browse/YARN-6807
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: documentation, federation
>    Affects Versions: YARN-2915
>            Reporter: Subru Krishnan
>            Assignee: Tanuj Nayak
>         Attachments: YARN-6807-YARN-2915-v1.2.patch, 
> YARN-6807-YARN-2915-v1.patch
>
>
> We identified some missing configs that are required for e2e run. This JIRA 
> proposes to update the documentation to include the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to