[
https://issues.apache.org/jira/browse/YARN-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086397#comment-16086397
]
Carlo Curino commented on YARN-6815:
------------------------------------
Hi Subru, thanks for the contribution!
Few minor issues about logging/exception throwing:
# {{RouterPolicyFacade (165)}} you should have the try/catch also for the
default-key, in case there are SQL errors (to avoid availability issues)
# {{RouterPolicyFacade}} we should use {{LOG.warn}}, as the fact that there are
exception in FederationStateStore is bad and we should log it
# {{SQLFederationStateStore (405)}} we should throw exception for non-null
{{subclusterInfo}}, and simply LOG.warn for null subclusterInfo.
Other than this I am +1 on this patch.
> [Bug] FederationStateStoreFacade return behavior should be consistent
> irrespective of whether caching is enabled or not
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6815
> URL: https://issues.apache.org/jira/browse/YARN-6815
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Subru Krishnan
> Attachments: YARN-6815-YARN-2915.v1.patch,
> YARN-6815-YARN-2915.v2.patch
>
>
> {{FederationStateStoreFacade::getSubCluster/getPolicyConfiguration}} returns
> null if caching is enabled or throws YarnException if caching is disabled if
> the queried entity is absent. This jira proposes to make the return
> consistent to ensure correctness of clients like {{RouterPolicyFacade}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
