[ https://issues.apache.org/jira/browse/YARN-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087770#comment-16087770 ]
Sangjin Lee commented on YARN-6771: ----------------------------------- Thanks for the contribution [~jongyoul]. It appears that the same pattern exists in {{RpcServerFactoryPBImpl}} too. To be consistent, we should change both or neither. That said, these are pretty basic classes that pin all YARN RPC communications. I don't see the full history, but it appears that using a clean configuration to load these classes was intentional. Could you please explain in bit more detail why you'd need to use provide a specific {{Configuration}} instance to create RPC clients/servers? Is there a JIRA or issue that describes an issue on your end? > Use classloader inside configuration class to make new classes > --------------------------------------------------------------- > > Key: YARN-6771 > URL: https://issues.apache.org/jira/browse/YARN-6771 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.8.1, 3.0.0-alpha4 > Reporter: Jongyoul Lee > Fix For: 2.8.2 > > Attachments: YARN-6771-1.patch, YARN-6771-2.patch, YARN-6771.patch > > > While running {{RpcClientFactoryPBImpl.getClient}}, > {{RpcClientFactoryPBImpl}} uses {{localConf.getClassByName}}. But in case of > using custom classloader, we have to use {{conf.getClassByName}} because > custom classloader is already stored in {{Configuration}} class. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org