[
https://issues.apache.org/jira/browse/YARN-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090777#comment-16090777
]
Subru Krishnan commented on YARN-6777:
--------------------------------------
Thanks [~asuresh] for splitting the patch, lot more understandable now.
I looked at the patch and have a few questions:
* In {{ApplicationMasterServiceInterceptor}}, I am not in favor of having
_nextProcessor_ for each method as they are not method-dependent. Can we have a
simple *setNextProcessor* instead? Additionally we should invoke it locally and
then pass to the next interceptor.
* With the above changes:
** {{ApplicationMasterServiceInterceptor}} can implement
{{ApplicationMasterServiceProcessor}}.
** IIUC, the {{Processor}} is also redundant
* In {{AMSProcessingChain}}, don't grok why we need both _head_ and _root_?
* Nit: can you please add more code comments for readability and class names
are a bit confusing :).
> Support for ApplicationMasterService processing chain of interceptors
> ---------------------------------------------------------------------
>
> Key: YARN-6777
> URL: https://issues.apache.org/jira/browse/YARN-6777
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-6777.001.patch, YARN-6777.002.patch,
> YARN-6777.003.patch
>
>
> This JIRA extends the Processor introduced in YARN-6776 with a configurable
> processing chain of interceptors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
