[ 
https://issues.apache.org/jira/browse/YARN-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092289#comment-16092289
 ] 

Daniel Templeton commented on YARN-6778:
----------------------------------------

It should be final because it is invoked in the constructor.  Overridable 
methods called from a constructor can cause issues.  See 
https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors.

> In ResourceWeights, weights and setWeights() should be final
> ------------------------------------------------------------
>
>                 Key: YARN-6778
>                 URL: https://issues.apache.org/jira/browse/YARN-6778
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.8.1, 3.0.0-alpha4
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-6778.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to