[
https://issues.apache.org/jira/browse/YARN-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094484#comment-16094484
]
Varun Saxena commented on YARN-6733:
------------------------------------
Thanks [~vrushalic] for the patch and [~rohithsharma] for the reviews.
Patch LGTM. I noticed a few nits while reading the code though.
# Rowkey mentioned in class javadoc of SubApplicationTable class is incorrect.
In the same javadoc, configKey2 is mentioned under column family, metrics.
# SubApplicationRowKey L181 mentions the rowkey incorrectly. clusterid should
follow subappuserid.
# SubApplicationRowKey L204 the variable is named as enitityIdPrefix. Should be
entityIdPrefix
> Add table for storing sub-application entities
> ----------------------------------------------
>
> Key: YARN-6733
> URL: https://issues.apache.org/jira/browse/YARN-6733
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Vrushali C
> Attachments: IMG_7040.JPG, YARN-6733-YARN-5355.001.patch,
> YARN-6733-YARN-5355.002.patch, YARN-6733-YARN-5355.003.patch,
> YARN-6733-YARN-5355.004.patch, YARN-6733-YARN-5355.005.patch
>
>
> After a discussion with Tez folks, we have been thinking over introducing a
> table to store sub-application information.
> For example, if a Tez session runs for a certain period as User X and runs a
> few AMs. These AMs accept DAGs from other users. Tez will execute these dags
> with a doAs user. ATSv2 should store this information in a new table perhaps
> called as "sub_application" table.
> This jira tracks the code changes needed for table schema creation.
> I will file other jiras for writing to that table, updating the user name
> fields to include sub-application user etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
