[ 
https://issues.apache.org/jira/browse/YARN-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098234#comment-16098234
 ] 

Sunil G commented on YARN-3254:
-------------------------------

Thanks [~suma.shivaprasad]
Generally patch looks fine. Few minor comments.

# I think  {{DirectoryCollection#getErroredDirs}} is a public api. Could u 
please mark as evolving and some more information in api. I think existing java 
doc is not that great there. However its better we do that.
# {{fullLocalDirsList}} could be renamed as {{diskFullLocalDirsList}} or some 
better name :) similar for logdirs as well.


> HealthReport should include disk full information
> -------------------------------------------------
>
>                 Key: YARN-3254
>                 URL: https://issues.apache.org/jira/browse/YARN-3254
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Akira Ajisaka
>            Assignee: Suma Shivaprasad
>             Fix For: 3.0.0-beta1
>
>         Attachments: Screen Shot 2015-02-24 at 17.57.39.png, Screen Shot 
> 2015-02-25 at 14.38.10.png, YARN-3254-001.patch, YARN-3254-002.patch, 
> YARN-3254-003.patch
>
>
> When a NodeManager's local disk gets almost full, the NodeManager sends a 
> health report to ResourceManager that "local/log dir is bad" and the message 
> is displayed on ResourceManager Web UI. It's difficult for users to detect 
> why the dir is bad.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to