[
https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100732#comment-16100732
]
Hudson commented on YARN-6307:
------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12054 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/12054/])
YARN-6307. Refactor FairShareComparator#compare (Contributed by Yufei Gu
(templedf: rev f81a4efb8c40f99a9a6b7b42d3b6eeedf43eb27a)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FairSharePolicy.java
> Refactor FairShareComparator#compare
> ------------------------------------
>
> Key: YARN-6307
> URL: https://issues.apache.org/jira/browse/YARN-6307
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-6307.001.patch, YARN-6307.002.patch,
> YARN-6307.003.patch
>
>
> The method does three things: compare the min share usage, compare fair share
> usage by checking weight ratio, break tied by submit time and name. They are
> mixed with each other which is not easy to read and maintenance, poor style.
> Additionally, there are potential performance issues, like no need to check
> weight ratio if minShare usage comparison already indicate the order. It is
> worth to improve considering huge amount invokings in scheduler.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
