[
https://issues.apache.org/jira/browse/YARN-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102550#comment-16102550
]
Giovanni Matteo Fumarola commented on YARN-5412:
------------------------------------------------
Thanks [~curino]. Pushed v6.
Fixed the remaining Yetus warning except the 4 checkstyles in
{{RouterWebServices}}, due to default param in reservation rest call the lines
are longer than 80.
1. Addressed.
2. Addressed.
3. Opened YARN-6887.
4. Added a comment. We can have {{hsr}} with the query params inside or the
{{additionalParam}}.
5. Good point. It does not matter since the Router will convert the XML/Json to
an object again and convert to XML/Json before answer to the Client.
All the calls from Router to RM will be in XML, while between the client and
the router can be in both format. There will be no changes from Client side.
I changed {{TestRouterWebServicesREST}} to have some calls from the client in
XML and some in Json to validate my point.
6. I am not doing a general equality test because I am running with a live RM
and the test makes a similar (but separate) call to RM.
Let me give you an example:
* t0) the test1 submits an application *app1*;
* t1) the test1 finishes at t1;
* t2) the test2 (independent from test1) asks some detail information - as
running containers or active MB - to the yarn rm;
* t3) an *app1*'s container goes from accepted to running;
* t4) the test2 asks the same detail information to the router. At this point
all the information are not the same.
For this reason, I am restricting my checking to values that do not change over
time.
> Create a proxy chain for ResourceManager REST API in the Router
> ---------------------------------------------------------------
>
> Key: YARN-5412
> URL: https://issues.apache.org/jira/browse/YARN-5412
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-5412-YARN-2915.1.patch,
> YARN-5412-YARN-2915.2.patch, YARN-5412-YARN-2915.3.patch,
> YARN-5412-YARN-2915.4.patch, YARN-5412-YARN-2915.5.patch,
> YARN-5412-YARN-2915.6.patch, YARN-5412-YARN-2915.proto.patch
>
>
> As detailed in the proposal in the umbrella JIRA, we are introducing a new
> component that routes client request to appropriate ResourceManager(s). This
> JIRA tracks the creation of a proxy for ResourceManager REST API in the
> Router. This provides a placeholder for:
> 1) throttling mis-behaving clients (YARN-1546)
> 3) mask the access to multiple RMs (YARN-3659)
> We are planning to follow the interceptor pattern like we did in YARN-2884 to
> generalize the approach and have only dynamically coupling for Federation.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
