[
https://issues.apache.org/jira/browse/YARN-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108129#comment-16108129
]
Jian He commented on YARN-6872:
-------------------------------
bq. In normalizeAndValidateRequest, we check for the node label disabled check
before looking for isRecovery flag. We could do some optimization here, but its
a public api. I will check all references.
Basically, if we check isRecovery outside, then the isRecovery flag parameter
is redundant. I was checking if other methods in normalizeAndValidateRequest
was needed for recovery such as
SchedulerUtils.normalizeNodeLabelExpressionInRequest.
I think this is still required if node label is enabled and this is recovery ？
bq. This could be removed. Just a thought ,that log is helpful rt. If we need
that log, i guess some checks are needed there.
Just for logging, we could do it inside normalizeAndValidateRequest itself
which will be simpler
> Ensure apps could run given NodeLabels are disabled post RM switchover/restart
> ------------------------------------------------------------------------------
>
> Key: YARN-6872
> URL: https://issues.apache.org/jira/browse/YARN-6872
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-6872.001.patch
>
>
> Post YARN-6031, few apps could be failed during recovery provided they had
> some label requirements for AM and labels were disable post RM
> restart/switchover. As discussed in YARN-6031, its better to run such apps as
> it may be long running apps as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
