[ https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108381#comment-16108381 ]
Akira Ajisaka commented on YARN-6873: ------------------------------------- {code:title=NavBlock.java} Log log = LogFactory.getLog(NavBlock.class); if (log instanceof Log4JLogger) { Log4jWarningErrorMetricsAppender appender = Log4jWarningErrorMetricsAppender.findAppender(); if (appender != null) { addErrorsAndWarningsLink = true; } {code} In the above code, {{log instanceof Log4JLogger}} will be false if the api is moved to slf4j. The following change may work {code:title=NavBlock.java} Logger log = LoggerFactory.getLogger(NavBlock.class); if (log instanceof Log4jLoggerAdapter) { Log4jWarningErrorMetricsAppender appender = Log4jWarningErrorMetricsAppender.findAppender(); if (appender != null) { addErrorsAndWarningsLink = true; } {code} however, we need to verify it actually works. > Moving logging APIs over to slf4j in > hadoop-yarn-server-applicationhistoryservice > --------------------------------------------------------------------------------- > > Key: YARN-6873 > URL: https://issues.apache.org/jira/browse/YARN-6873 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Yeliang Cang > Assignee: Yeliang Cang > Attachments: YARN-6873.001.patch, YARN-6873.002.patch, > YARN-6873.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org