[
https://issues.apache.org/jira/browse/YARN-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109883#comment-16109883
]
Eric Payne commented on YARN-6846:
----------------------------------
The patch looks good in general, but there is one thing I'd like to clear up.
If I'm reading the man pages correctly for {{geteuid()}}, {{seteuid()}}, and
{{readdir()}}, they don't generate {{ENOENT}}. If that is true, then the
following changes are not necessary:
{noformat}
@@ -1837,7 +1837,7 @@ static int rmdir_as_nm(const char* path) {
@@ -1985,7 +2005,7 @@ static int recursive_unlink_helper(int dirfd, const char
*name,
{noformat}
Thoughts?
> Nodemanager can fail to fully delete application local directories when
> applications are killed
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-6846
> URL: https://issues.apache.org/jira/browse/YARN-6846
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.8.1
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Priority: Critical
> Attachments: YARN-6846.001.patch, YARN-6846.002.patch,
> YARN-6846.003.patch
>
>
> When an application is killed all of the running containers are killed and
> the app waits for the containers to complete before cleaning up. As each
> container completes the container directory is deleted via the
> DeletionService. After all containers have completed the app completes and
> the app directory is deleted. If the app completes quickly enough then the
> deletion of the container and app directories can race against each other.
> If the container deletion executor deletes a file just before the application
> deletion executor then it can cause the application deletion executor to
> fail, leaving the remaining entries in the application directory lingering.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
