[
https://issues.apache.org/jira/browse/YARN-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111695#comment-16111695
]
Daniel Templeton edited comment on YARN-6788 at 8/2/17 10:10 PM:
-----------------------------------------------------------------
Just a few little quibbles, and I think we're done:
* There's an unused import in {{DominantResourceCalculator}}.
* In {{Resource.hashCode()}}, this:{code} for (ResourceInformation entry :
getResources()) {
if (entry.getName().equals(MEMORY)
|| entry.getName().equals(VCORES)) {
continue;
}
result = prime * result + entry.hashCode();
}{code} would be much clearer as: {code} for (ResourceInformation entry
: getResources()) {
if (!entry.getName().equals(MEMORY) &&
!entry.getName().equals(VCORES)) {
result = prime * result + entry.hashCode();
}
}{code}
* In {{ResourcePBImpl.initResources()}} there should be a space after the _if_
in {{if(index == null)}}.
* {{ResourcePMImpl.setResourceInformation()}} and {{setResourceValue()}} should
call {{getResourceInformation()}} instead of duplicating the logic.
* Just curious, why do we need node labels enabled in {{TestAppManager}} for
this patch?
was (Author: templedf):
Just a few of little quibbles, and I think we're done:
* There's an unused import in {{DominantResourceCalculator}}.
* In {{Resource.hashCode()}}, this:{code} for (ResourceInformation entry :
getResources()) {
if (entry.getName().equals(MEMORY)
|| entry.getName().equals(VCORES)) {
continue;
}
result = prime * result + entry.hashCode();
}{code} would be much clearer as: {code} for (ResourceInformation entry
: getResources()) {
if (!entry.getName().equals(MEMORY) &&
!entry.getName().equals(VCORES)) {
result = prime * result + entry.hashCode();
}
}{code}
* In {{ResourcePBImpl.initResources()}} there should be a space after the _if_
in {{if(index == null)}}.
* {{ResourcePMImpl.setResourceInformation()}} and {{setResourceValue()}} should
call {{getResourceInformation()}} instead of duplicating the logic.
* Just curious, why do we need node labels enabled in {{TestAppManager}} for
this patch?
> Improve performance of resource profile branch
> ----------------------------------------------
>
> Key: YARN-6788
> URL: https://issues.apache.org/jira/browse/YARN-6788
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Sunil G
> Assignee: Sunil G
> Priority: Blocker
> Attachments: YARN-6788-YARN-3926.001.patch,
> YARN-6788-YARN-3926.002.patch, YARN-6788-YARN-3926.003.patch,
> YARN-6788-YARN-3926.004.patch, YARN-6788-YARN-3926.005.patch,
> YARN-6788-YARN-3926.006.patch, YARN-6788-YARN-3926.007.patch,
> YARN-6788-YARN-3926.008.patch, YARN-6788-YARN-3926.009.patch,
> YARN-6788-YARN-3926.010.patch, YARN-6788-YARN-3926.011.patch,
> YARN-6788-YARN-3926.012.patch, YARN-6788-YARN-3926.013.patch,
> YARN-6788-YARN-3926.014.patch, YARN-6788-YARN-3926.015.patch,
> YARN-6788-YARN-3926.016.patch, YARN-6788-YARN-3926.017.patch,
> YARN-6788-YARN-3926.018.patch, YARN-6788-YARN-3926.019.patch,
> YARN-6788-YARN-3926.020.patch, YARN-6788-YARN-3926.021.patch
>
>
> Currently we could see a 15% performance delta with this branch.
> Few performance improvements to improve the same.
> Also this patch will handle
> [comments|https://issues.apache.org/jira/browse/YARN-6761?focusedCommentId=16075418&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16075418]
> from [~leftnoteasy].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
