[
https://issues.apache.org/jira/browse/YARN-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111855#comment-16111855
]
Daniel Templeton commented on YARN-4081:
----------------------------------------
I have a question about the {{UnitsConversionUtil}} added in this patch and
units in resource types in general. As far as I can tell, we only convert
units when attempting to compare {{Resource}} instances (or
{{ResourceInformation}} instances to the same effect). We do the conversion
when the units for a resource type in one {{Resource}} instance don't match the
units for that resource type in the other {{Resource}} instance. The units for
the resource types are set globally by the {{ResourceUtils}} class, so they
can't ever differ across {{Resource}} instances. As far as I can tell, units
are really just flags we attach to a resource type to give the user additional
information. We don't seem to use them for any actual purpose in the code. Am
I missing something?
> Add support for multiple resource types in the Resource class
> -------------------------------------------------------------
>
> Key: YARN-4081
> URL: https://issues.apache.org/jira/browse/YARN-4081
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Fix For: YARN-3926
>
> Attachments: YARN-4081-YARN-3926.001.patch,
> YARN-4081-YARN-3926.002.patch, YARN-4081-YARN-3926.003.patch,
> YARN-4081-YARN-3926.004.patch, YARN-4081-YARN-3926.005.patch,
> YARN-4081-YARN-3926.006.patch, YARN-4081-YARN-3926.007.patch,
> YARN-4081-YARN-3926.008.patch
>
>
> For adding support for multiple resource types, we need to add support for
> this in the Resource class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
