[ 
https://issues.apache.org/jira/browse/YARN-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111894#comment-16111894
 ] 

Giovanni Matteo Fumarola commented on YARN-6871:
------------------------------------------------

Thanks [~tanujnay] for the patch.
Few starting feedback:
* You have to set up in your eclipse/intelJ the 
[formatter|https://github.com/cloudera/blog-eclipse/blob/master/hadoop-format.xml]
 to use hadoop formatter.
* You add an useless import {{sun.security.krb5.internal.crypto.Des;}}. Please 
remove it.
* Try to improve the comment in {{DeSelectFields}}.
* Let add a test for each field. Check how they did in YARN-6820.
* For timeout param, you have to skip the entire {{if 
(applicationTimeouts.isEmpty()) }}.

> Add additional deSelects params in getAppReport
> -----------------------------------------------
>
>                 Key: YARN-6871
>                 URL: https://issues.apache.org/jira/browse/YARN-6871
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: resourcemanager, router
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Tanuj Nayak
>         Attachments: YARN-6871.proto.patch
>
>
> This jira tracks the effort to add additional deSelect params to the 
> GetAppReport to make it lighter and faster.
> With the current one we are facing a scalability issues.
> E.g. with ~500 applications running the AppReport can reach up to 300MB in 
> size due to the {{ResourceRequest}} in the {{AppInfo}}.
> Yarn RM will return the new result faster and it will use less compute cycles 
> to create the report and it will improve the YARN RM and Client's 
> performances.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to