[
https://issues.apache.org/jira/browse/YARN-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113449#comment-16113449
]
Subru Krishnan commented on YARN-6900:
--------------------------------------
Thanks [~elgoiri] for updating the patch. The latest version is very close,
couple of minor comments:
* Based on the discussion with [~zhz]/[~leftnoteasy]/[~drankye] in YARN-6840,
we should simply merge what you have in {{YarnZKUtils}} in {{ZKUtils}} in
hadoop-common.
* I am aware the util code is covered as part of the individual store tests but
do you think it makes sense to add some basic tests?
* Looks like you missed including the documentation update in the patch.
> ZooKeeper based implementation of the FederationStateStore
> ----------------------------------------------------------
>
> Key: YARN-6900
> URL: https://issues.apache.org/jira/browse/YARN-6900
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Inigo Goiri
> Attachments: YARN-6900-002.patch, YARN-6900-YARN-2915-000.patch,
> YARN-6900-YARN-2915-001.patch
>
>
> YARN-5408 defines the unified {{FederationStateStore}} API. Currently we only
> support SQL based stores, this JIRA tracks adding a ZooKeeper based
> implementation for simplifying deployment as it's already popularly used for
> {{RMStateStore}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
