[ 
https://issues.apache.org/jira/browse/YARN-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114235#comment-16114235
 ] 

Rohith Sharma K S commented on YARN-6133:
-----------------------------------------

thanks @varun for the patch. 
Some comments
# Token is renewed just before 10 seconds. Should it be increased?
# TimelineCollectorManager has introduced synchronized block. This is not 
necessary right.?
# Renewer threads count is 1. Given load on NM not much, one thread can renew 
it. But I would suggest to keep it to 50? 

> [ATSv2 Security] Renew delegation token for app automatically if an app 
> collector is active
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-6133
>                 URL: https://issues.apache.org/jira/browse/YARN-6133
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6133-YARN-5355.01.patch, 
> YARN-6133-YARN-5355.02.patch, YARN-6133-YARN-5355.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to