[ 
https://issues.apache.org/jira/browse/YARN-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114391#comment-16114391
 ] 

Naganarasimha G R commented on YARN-6727:
-----------------------------------------

Thanks [~bibinchundatt], 
At first glance, approach looks good to me but few nits i observed was :
 # YarnAuthorizationProvider.java ln 122: ??Get all permissions?? is invalid
 # ClientRMService.java ln no 1022: there is possibility that the user is not 
admin but set his name as {{userName}} in the request, hence we should not 
throw exception
 # ClientRMService.java ln no 1026 - 1039 : logic can be little optimized as we 
are calling twice  {{queueACLsManager.getUserQueueACLInfo(queueNames, 
userUGI))}}
 # Some checkstyle issues seems to be valid
 
Will review completely and update if any more present.

> Improve getQueueUserAcls API to query for  specific queue and user
> ------------------------------------------------------------------
>
>                 Key: YARN-6727
>                 URL: https://issues.apache.org/jira/browse/YARN-6727
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6727.001.patch, YARN-6727.WIP.patch
>
>
> Currently {{ApplicationClientProtocol#getQueueUserAcls}} return data for all 
> the queues available in scheduler for user.
> User wants to know whether he has rights of a particular queue only. For 
> systems with 5K queues returning all queues list is not efficient.
> Suggested change: support additional parameters *userName and queueName* as 
> optional. Admin user should be able to query other users ACL for a particular 
> queueName.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to