[ 
https://issues.apache.org/jira/browse/YARN-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115785#comment-16115785
 ] 

Naganarasimha G R commented on YARN-65:
---------------------------------------

Hi [~maniraj...@gmail.com],
thanks for providing the patch, please find my comments for the same
# RMAppImpl ln no 1095, not required
# RMAppImpl ln no 2022,  why you need reference to RMAppImpl as method argument 
? its not a static method IMO let the method be just a method in RMAppImpl. And 
let the method name be more meaningful (clearUnrequiredFields or something)
# TestRMAppTransitions ln no 21, Import the required classes
# TestRMAppTransitions ln no 131 & 132, Why localFS & tmpDir required to be 
fields? It can just be local variables right ?
# TestRMAppTransitions ln no 300, 351, please format the code based on the 
hadoop template for the modified code, and many of the check style issues are 
related to it. And as well fix other checkstyle issues
# TestRMAppTransitions ln no 1235, method name can be more meaningfull, 
{{verifyUnusedFields}} -> {{verifyRMAppFieldsForNonFinalTransitions}} and 
{{verifyUnusedFieldsForNullValues}} --> {{verifyRMAppFieldsForFinalTransitions}}




> Reduce RM app memory footprint once app has completed
> -----------------------------------------------------
>
>                 Key: YARN-65
>                 URL: https://issues.apache.org/jira/browse/YARN-65
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Manikandan R
>         Attachments: YARN-65.001.patch, YARN-65.002.patch, YARN-65.003.patch, 
> YARN-65.004.patch
>
>
> The ResourceManager holds onto a configurable number of completed 
> applications (yarn.resource.max-completed-applications, defaults to 10000), 
> and the memory footprint of these completed applications can be significant.  
> For example, the {{submissionContext}} in RMAppImpl contains references to 
> protocolbuffer objects and other items that probably aren't necessary to keep 
> around once the application has completed.  We could significantly reduce the 
> memory footprint of the RM by releasing objects that are no longer necessary 
> once an application completes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to