[
https://issues.apache.org/jira/browse/YARN-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116182#comment-16116182
]
Rohith Sharma K S commented on YARN-6820:
-----------------------------------------
Couple of more comments
# Can you rename isEnabled to isAuthEnabled or something meaningful name?
# simplify below code directly to *String isEnabledStr =
Boolean.valueOf(conf.getInitParameter(YarnConfiguration.TIMELINE_SERVICE_READ_AUTH_ENABLED))*.
{code}
String isEnabledStr =
conf.getInitParameter(YarnConfiguration.TIMELINE_SERVICE_READ_AUTH_ENABLED);
if (isEnabledStr == null)
isEnabled = false;
else
isEnabled = Boolean.valueOf(isEnabledStr);
{code}
# {{listAllowedUsers == null}} null check is not required since initializer
already adds with "*"
# In TimelineReaderWhitelistAuthorizationFilterInitializer#initFilter, user
default value parameter instead of directly using string "*"
# doFilter method can be simplified.
## I am not sure if (chain != null) is required. chain.doFilter could be moved
to at the end after if (!isEnabled) which is applicable for both.
## I am not sure how much it is good throwing exception from doFilter methods!.
Other way is setting error code in response. response.sendErrors()
> Restrict read access to timelineservice v2 data
> ------------------------------------------------
>
> Key: YARN-6820
> URL: https://issues.apache.org/jira/browse/YARN-6820
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Vrushali C
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6820-YARN-5355.0001.patch,
> YARN-6820-YARN-5355.002.patch
>
>
> Need to provide a way to restrict read access in ATSv2. Not all users should
> be able to read all entities. On the flip side, some folks may not need any
> read restrictions, so we need to provide a way to disable this access
> restriction as well.
> Initially this access restriction could be done in a simple way via a
> whitelist of users allowed to read data. That set of users can read all data,
> no other user can read any data. Can be turned off for all users to read all
> data.
> Could be stored in a "domain" table in hbase perhaps. Or a configuration
> setting for the cluster. Or something else that's simple enough. ATSv1 has a
> concept of domain for isolating users for reading. Would be good to keep that
> in consideration.
> In ATSv1, domain offers a namespace for Timeline server allowing users to
> host multiple entities, isolating them from other users and applications. A
> “Domain” in ATSV1 primarily stores owner info, read and& write ACL
> information, created and modified time stamp information. Each Domain is
> identified by an ID which must be unique across all users in the YARN cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
