[
https://issues.apache.org/jira/browse/YARN-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117607#comment-16117607
]
Wangda Tan edited comment on YARN-6852 at 8/8/17 12:19 AM:
-----------------------------------------------------------
Again, thanks [[email protected]] for your reviews.
bq. could not find a doc about this, so I ask. Is there a reason to have a
disable list of devices, instead of an enable list?
Actually whitelist doesn't work for me, I tried to debug however I cannot find
the root cause. Since blacklist and whitelist are just two different approaches
for the same purpose. I think we could continue this approach, do you have any
concern here?
And regarding to file name style. I was just about to rename to underscore,
however I found the container-executor itself is "\-", I suggest to convert
existing files to "\-" connected, otherwise we have to rename a lot of files. I
don't quite care about which style to go, I just want to avoid change too many
file.
Attached ver.004 patch, (TODO): unit test related cleanups.
was (Author: leftnoteasy):
Again, thanks [[email protected]] for your reviews.
bq. could not find a doc about this, so I ask. Is there a reason to have a
disable list of devices, instead of an enable list?
Actually whitelist doesn't work for me, I tried to debug however I cannot find
the root cause. Since blacklist and whitelist are just two different approaches
for the same purpose. I think we could continue this approach, do you have any
concern here?
And regarding to file name style. I was just about to rename to underscore,
however I found the container-executor itself is "-", I suggest to convert
existing files to "-" connected, otherwise we have to rename a lot of files. I
don't quite care about which style to go, I just want to avoid change too many
file.
Attached ver.004 patch, (TODO): unit test related cleanups.
> [YARN-6223] Native code changes to support isolate GPU devices by using
> CGroups
> -------------------------------------------------------------------------------
>
> Key: YARN-6852
> URL: https://issues.apache.org/jira/browse/YARN-6852
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6852.001.patch, YARN-6852.002.patch,
> YARN-6852.003.patch, YARN-6852.004.patch
>
>
> This JIRA plan to add support of:
> 1) Isolation in CGroups. (native side).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
