[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117675#comment-16117675
]
Miklos Szegedi commented on YARN-6033:
--------------------------------------
Thank you for the patch [~wangda]. The last comments are style only, the patch
looks good to me otherwise (non-binding).
{code}
493 cfg->sections = (struct section **) malloc(
494 sizeof(struct section *) * MAX_SIZE);
{code}
There is a missing NULL check here.
{code}
466 if (free_second_section) {
467 free(section2->name);
468 memset(section2, 0, sizeof(*section2));
469 free(section2);
470 }
{code}
I commented earlier to remove free_second_section. If we keep it, we might want
to add a unit test and still do memset(section2, 0, sizeof(*section2)), if
free_second_section is 0; This is a note only. We can do it in another jira,
since this is dead code.
{code}
513 const struct section *existing_section =
514 get_configuration_section(new_section->name, cfg);
{code}
This variable is actually not const. We modify the structure.
> Add support for sections in container-executor configuration file
> -----------------------------------------------------------------
>
> Key: YARN-6033
> URL: https://issues.apache.org/jira/browse/YARN-6033
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-6033.003.patch, YARN-6033.004.patch,
> YARN-6033.005.patch, YARN-6033.006.patch, YARN-6033.007.patch,
> YARN-6033.008.patch, YARN-6033.009.patch, YARN-6033.010.patch,
> YARN-6033.011.patch, YARN-6033.012.patch, YARN-6033-YARN-5673.001.patch,
> YARN-6033-YARN-5673.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
