[ https://issues.apache.org/jira/browse/YARN-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118388#comment-16118388 ]
Haibo Chen commented on YARN-6668: ---------------------------------- Sorry for being nit-picky. Can you fix the checkstyle issues? Also, I think the two statements "Assert.assertEquals("Expected exception", null, calculator);" in testNoPidFound() and testNoMemoryCGgroupMount() are dead code, and thus can be safely removed. Otherwise, the patch LGTM. > Use cgroup to get container resource utilization > ------------------------------------------------ > > Key: YARN-6668 > URL: https://issues.apache.org/jira/browse/YARN-6668 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 3.0.0-alpha3 > Reporter: Haibo Chen > Assignee: Miklos Szegedi > Attachments: YARN-6668.000.patch, YARN-6668.001.patch, > YARN-6668.002.patch, YARN-6668.003.patch, YARN-6668.004.patch > > > Container Monitor relies on proc file system to get container resource > utilization, which is not as efficient as reading cgroup accounting. We > should in NM, when cgroup is enabled, read cgroup stats instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org