[ 
https://issues.apache.org/jira/browse/YARN-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118970#comment-16118970
 ] 

Wangda Tan commented on YARN-6892:
----------------------------------

Rekicked Jenkins, [~sunilg], looked at the patch again, the biggest issue I can 
see is, added method: getResourceInformation/setResourceInformation doesn't 
properly verify index ranges. I think we need to add check to make sure 
getResourceInformation(index) returns existing ResourceInformation or at least 
throw exception, and DominantResourceCalculator should properly handle that as 
well. I'm a little bit worried that, for now is it possible that an app can 
request a unknown resource type (by calling setResourceInformation("foo", bar)) 
and bring down the cluster. Do we have any check for this?

> Improve API implementation in Resources and DominantResourceCalculator in 
> align to ResourceInformation
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6892
>                 URL: https://issues.apache.org/jira/browse/YARN-6892
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: YARN-6892-YARN-3926.001.patch
>
>
> In YARN-3926, apis in Resources and DRC spents significant cpu cycles in most 
> of its api. For better performance, its better to improve the apis as 
> resource types order is defined in system level (ResourceUtils class ensures 
> this post YARN-6788)
> This work is preceding to YARN-6788



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to