[
https://issues.apache.org/jira/browse/YARN-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120417#comment-16120417
]
Jason Lowe commented on YARN-6917:
----------------------------------
Thanks for the patch, Eric! I agree with the checkstyle nit: the new queuePath
field should be private. Other than that I think it looks good. Agree that
this is an optimization and the testing should be covered by existing
reconfiguration tests.
> Queue path is recomputed from scratch on every allocation
> ---------------------------------------------------------
>
> Key: YARN-6917
> URL: https://issues.apache.org/jira/browse/YARN-6917
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacityscheduler
> Affects Versions: 2.8.1
> Reporter: Jason Lowe
> Assignee: Eric Payne
> Priority: Minor
> Attachments: YARN-6917.001.patch
>
>
> As part of the discussion in YARN-6901 I noticed that we are recomputing a
> queue's path for every allocation. Currently getting the queue's path
> involves calling getQueuePath on the parent then building onto that string
> with the basename of the queue. In turn the parent's getQueuePath method
> does the same, so we end up spending time recomputing a string that will
> never change until a reconfiguration.
> Ideally the queue path should be computed once during queue initialization
> rather than on-demand.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
