Vrushali C updated YARN-6874:
    Attachment: YARN-6874-YARN-5355.0001.patch

Thanks [~varun_saxena]. yes I think if two writes happen within the same 
millisecond for the min start time, the second one will overwrite the other. 
Which is exactly why we are supplementing the timestamp for metric writes in 
the flow run table.

I am attaching a very simple patch that modifies the ColumnHelper constructor 
call to include "true" for the flag that indicates the use of supplemented 
timestamp while storing.

The effect of this will be that for columns min start time and max end time of 
the flow, the supplemented timestamp will be used correctly. It will also be 
invoked for the flow version column store, so the biggest timestamp value will 
be fetched when we query for the flow version. The effect is the same as 
different apps writing the flow version.

Uploading v001.

> TestHBaseStorageFlowRun.testWriteFlowRunMinMax fails intermittently
> -------------------------------------------------------------------
>                 Key: YARN-6874
>                 URL: https://issues.apache.org/jira/browse/YARN-6874
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Vrushali C
>         Attachments: YARN-6874-YARN-5355.0001.patch
> {noformat}
> testWriteFlowRunMinMax(org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun)
>   Time elapsed: 0.088 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<1425026900000> but was:<1425026901000>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at org.junit.Assert.assertEquals(Assert.java:542)
>       at 
> org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun.testWriteFlowRunMinMax(TestHBaseStorageFlowRun.java:237)
> {noformat}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to