[ 
https://issues.apache.org/jira/browse/YARN-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120781#comment-16120781
 ] 

Vrushali C commented on YARN-6861:
----------------------------------

Thanks for the patch [~rohithsharma]. 

Overall the patch looks good. 

I had some thoughts for discussion. 
- I am wondering if the rest api name should also indicate that this is not a 
regular entity but a sub app entity. For example, can we rename the API 
"/users/{userid}/entities/{entitytype}/{entityid}" to something like 
"/subappusers/{userid}/subappentities/{entitytype}/{entityid}"
- similarly for other apis.
- instead of doAsUser, wondering we should name it subAppUser? 


> Reader API for sub application entities
> ---------------------------------------
>
>                 Key: YARN-6861
>                 URL: https://issues.apache.org/jira/browse/YARN-6861
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: YARN-6861-YARN-5355.001.patch, 
> YARN-6861-YARN-5355.002.patch
>
>
> YARN-6733 and YARN-6734 writes data into sub application table. There should 
> be a way to read those entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to