[
https://issues.apache.org/jira/browse/YARN-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121019#comment-16121019
]
Junping Du commented on YARN-6259:
----------------------------------
Thanks for the patch, [~Tao Yang]! It looks like we have performance
improvement here with mixing a new requirement of pagination. Can we split the
patch into two different parts? I believe no argument on performance gains and
we can have separated discussion on pagination requirement. Make sense?
> Support pagination and optimize data transfer with zero-copy approach for
> containerlogs REST API in NMWebServices
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6259
> URL: https://issues.apache.org/jira/browse/YARN-6259
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.8.1
> Reporter: Tao Yang
> Assignee: Tao Yang
> Attachments: YARN-6259.001.patch
>
>
> Currently containerlogs REST API in NMWebServices will read and send the
> entire content of container logs. Most of container logs are large and it's
> useful to support pagination.
> * Add pagesize and pageindex parameters for containerlogs REST API
> {code}
> URL: http://<nm_address>/ws/v1/node/containerlogs/<container_id>/<file_name>
> QueryParams:
> pagesize - max bytes of one page , default 1MB
> pageindex - index of required page, default 0, can be nagative(set -1 will
> get the last page content)
> {code}
> * Add containerlogs-info REST API since sometimes we need to know the
> totalSize/pageSize/pageCount info of log
> {code}
> URL:
> http://<nm_address>/ws/v1/node/containerlogs-info/<container_id>/<file_name>
> QueryParams:
> pagesize - max bytes of one page , default 1MB
> Response example:
> {"logInfo":{"totalSize":2497280,"pageSize":1048576,"pageCount":3}}
> {code}
> Moreover, the data transfer pipeline (disk --> read buffer --> NM buffer -->
> socket buffer) can be optimized to pipeline(disk --> read buffer --> socket
> buffer) with zero-copy approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
