Giovanni Matteo Fumarola commented on YARN-6972:

Thanks [~tanujnay] for the patch. Good job.
Few feedback:
1) Move {{String subclusterId}} after {{AppTimeoutsInfo timeouts}}. Doing the 
same things for the tests and the get method. This will avoid future conflicts.
2) In the test, instead of setting {{YarnConfiguration.DEFAULT_RM_CLUSTER_ID}} 
please set a random word. e.g. "SubCluster1". In this way, you will validate if 
your code gets the correct one and not always the default.

> Adding RM ClusterId in AppInfo
> ------------------------------
>                 Key: YARN-6972
>                 URL: https://issues.apache.org/jira/browse/YARN-6972
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Tanuj Nayak
>         Attachments: YARN-6972.001.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to