[ 
https://issues.apache.org/jira/browse/YARN-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122558#comment-16122558
 ] 

Giovanni Matteo Fumarola edited comment on YARN-6896 at 8/10/17 11:54 PM:
--------------------------------------------------------------------------

Attached V3 that addressed your feedback.

I fixed in a different way from the one suggested. Each 
{{MockDefaultFederationInterceptorREST}} has its own {{SubClusterId}}. 

* CreateNewApplication returns an applicationId that depends on the 
{{SubClusterId}}. In my tests I validate the ApplicationId timestamp belongs to 
one of the subclusters in my test.
* SubmitApplication returns a response with its own {{SubClusterId}}. In my 
tests I validate the response has the same subclusterId from the one saved in 
the StateStore. During the submission I added the application submitted in a 
list inside the mock class.
* GetApplication and KillApplication have a check if the application was 
submitted in that subcluster. If not, the mock class throws an exception. In my 
test I validate I do not get any exception and I get a positive responses.

I validate the patch in a small test cluster.


was (Author: giovanni.fumarola):
Attached V3 that addressed your feedback.

I fixed in a different way from the one suggested. Each 
{{MockDefaultFederationInterceptorREST}} has its own {{SubClusterId}}. 

* CreateNewApplication returns an applicationId that depends on the 
{{SubClusterId}}. In my tests I validate the ApplicationId timestamp belongs to 
one of the subclusters in my test.
* SubmitApplication returns a response with its own {{SubClusterId}}. In my 
tests I validate the response has the same subclusterId from the one saved in 
the StateStore. During the submission I added the application submitted in a 
list inside the mock class.
* GetApplication and KillApplication have a check if the application was 
submitted in that subcluster. If not, the mock class throws an exception. In my 
test I validate I do not get any exception and I get a positive responses.


> Federation: routing REST invocations transparently to multiple RMs (part 1 - 
> basic execution)
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-6896
>                 URL: https://issues.apache.org/jira/browse/YARN-6896
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>         Attachments: YARN-6896.proto.patch, YARN-6896.v1.patch, 
> YARN-6896.v2.patch, YARN-6896.v3.patch
>
>
> This JIRA tracks the design/implementation of the layer for routing 
> RMWebServicesProtocol requests to the appropriate RM(s) in a federated YARN 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to