[ 
https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122737#comment-16122737
 ] 

Yu-Tang Lin commented on YARN-6885:
-----------------------------------

Hi [#Daniel Templeton], thanks for the comment!
I put the text and val object outside the switch case due to I can't reuse the 
same variable name just like the previous code in each case section, but just 
like you mentioned, it'll cost more to cast the variable.
About the comment 4 and 5, I tried the treat these two cases just like other 
cases in previous patch, but the finding-bugs plugin showed that the boxing 
issues might be occurred, so I added the brace and tried to use primitive 
variables.
Could you please give me some suggestions?

And I didn't get the comment 6, do you mean the code below should be put in the 
default case section? 
{code:java}
  if (isLeaf && !"parent".equals(element.getAttribute("type"))) {
      configuredQueues.get(FSQueueType.LEAF).add(queueName);
    } else {
      if (isReservable) {
        throw new AllocationConfigurationException("The configuration settings"
            + " for " + queueName + " are invalid. A queue element that "
            + "contains child queue elements or that has the type='parent' "
            + "attribute cannot also include a reservation element.");
      }
      configuredQueues.get(FSQueueType.PARENT).add(queueName);
    }
{code}

 


> AllocationFileLoaderService.loadQueue() should use a switch statement in the 
> main tag parsing loop instead of the if/else-if/...
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6885
>                 URL: https://issues.apache.org/jira/browse/YARN-6885
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Daniel Templeton
>            Assignee: Yu-Tang Lin
>            Priority: Minor
>              Labels: newbie
>             Fix For: 3.0.0-alpha4
>
>         Attachments: YARN-6885.005.patch
>
>
> {code}      if ("minResources".equals(field.getTagName())) {
>         String text = ((Text)field.getFirstChild()).getData().trim();
>         Resource val =
>             FairSchedulerConfiguration.parseResourceConfigValue(text);
>         minQueueResources.put(queueName, val);
>       } else if ("maxResources".equals(field.getTagName())) {
>       ...{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to