[ 
https://issues.apache.org/jira/browse/YARN-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe reassigned YARN-7014:
--------------------------------

             Assignee: Jason Lowe
    Affects Version/s: 3.0.0-beta1
             Priority: Critical  (was: Major)
              Summary: container-executor has off-by-one error which can 
corrupt the heap  (was: test-container-executor is failing with exit code 139)
     Target Version/s: 3.0.0-beta1

The test is failing because there's a memory corruption error in the 
container-executor code, and that triggers a crash in malloc.  At least one 
problem is in string_utils.c which has this classic off-by-one error:
{code}
  char* input_cpy = malloc(strlen(input));
  strcpy(input_cpy, input);
{code}

strlen does not account for the terminating NUL character, so we end up 
allocating one byte less than we need and then promptly scribble past the end 
of the allocation.

Looks like this was introduced by YARN-6726.

> container-executor has off-by-one error which can corrupt the heap
> ------------------------------------------------------------------
>
>                 Key: YARN-7014
>                 URL: https://issues.apache.org/jira/browse/YARN-7014
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.0.0-beta1
>            Reporter: Shane Kumpf
>            Assignee: Jason Lowe
>            Priority: Critical
>
> test-container-executor is failing in trunk.
> {code}
> [INFO] 
> [INFO] --- hadoop-maven-plugins:3.0.0-beta1-SNAPSHOT:cmake-test 
> (test-container-executor) @ hadoop-yarn-server-nodemanager ---
> [INFO] -------------------------------------------------------
> [INFO]  C M A K E B U I L D E R    T E S T
> [INFO] -------------------------------------------------------
> [INFO] test-container-executor: running 
> /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native/target/usr/local/bin/test-container-executor
> [INFO] with extra environment variables {}
> [INFO] STATUS: ERROR CODE 134 after 3714 millisecond(s).
> [INFO] -------------------------------------------------------
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 13:47 min
> [INFO] Finished at: 2017-08-12T12:58:55+00:00
> [INFO] Final Memory: 19M/296M
> [INFO] 
> ------------------------------------------------------------------------
> [WARNING] The requested profile "parallel-tests" could not be activated 
> because it does not exist.
> [WARNING] The requested profile "yarn-ui" could not be activated because it 
> does not exist.
> [ERROR] Failed to execute goal 
> org.apache.hadoop:hadoop-maven-plugins:3.0.0-beta1-SNAPSHOT:cmake-test 
> (test-container-executor) on project hadoop-yarn-server-nodemanager: Test 
> /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native/target/usr/local/bin/test-container-executor
>  returned ERROR CODE 134 -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to