[
https://issues.apache.org/jira/browse/YARN-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130363#comment-16130363
]
Manikandan R commented on YARN-6982:
------------------------------------
Attached patch for review.
Overall approach is to remove those lines where tokensconf has been set to null
and ensuring the same has been retained even after update (for ex, change in
priority) and recover events through test cases.
> Potential issue on setting AMContainerSpec#tokenConf to null before app is
> completed
> ------------------------------------------------------------------------------------
>
> Key: YARN-6982
> URL: https://issues.apache.org/jira/browse/YARN-6982
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Rohith Sharma K S
> Assignee: Manikandan R
> Attachments: YARN-6982.001.patch
>
>
> While reviewing patch for YARN-65, I found that many places
> RMAppImpl#submissionContext sets containerLaunchcontext#setTokensConf has
> been set to null i.e
> {code}
> // set the memory free
> app.submissionContext.getAMContainerSpec().setTokensConf(null);
> {code}
> This appears be a issue if application is updated may be because queue move
> or lifetime or priority, then submission context will be restored again into
> state store. Consider after app update, if RM is restarted then submission
> context will have null tokenConf. This could be a potential issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
