[ 
https://issues.apache.org/jira/browse/YARN-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130953#comment-16130953
 ] 

Daniel Templeton commented on YARN-6789:
----------------------------------------

bq. i'm not sure what did you mean, it is a valid usage to me.

What I mean is {{(null != x)}} versus {{(x != null)}}.  In C the reason to 
invert the order is that {{if (x = null)}} will compile and can be a 
hard-to-find bug.  {{if (null = x)}} won't compile, preventing the error.  In 
Java, {{if (x = null)}} already won't compile, so there's no reason to invert 
the args.

Since the asserts are all {{assertEquals()}}, I'm not going to block the patch 
for assert messages, but I do really like to have them. :)

> new api to get all supported resources from RM
> ----------------------------------------------
>
>                 Key: YARN-6789
>                 URL: https://issues.apache.org/jira/browse/YARN-6789
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: YARN-6789-YARN-3926.001.patch, 
> YARN-6789-YARN-3926.002_incomplete_.patch, YARN-6789-YARN-3926.003.patch, 
> YARN-6789-YARN-3926.004.patch, YARN-6789-YARN-3926.005.patch
>
>
> It will be better to provide an api to get all supported resource types from 
> RM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to